21 Jul
2020
21 Jul
'20
8:17 p.m.
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 20:
(1 comment)
Patch Set 20: Code-Review-1
please fix port C0 config.
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 64: SBU
sbu is fixed since you have a ps8815 in the path. this should be the same as C1.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/42301
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I59ce4720e0ffeeeb2c9440bb300686def80211ea
Gerrit-Change-Number: 42301
Gerrit-PatchSet: 20
Gerrit-Owner: Kane Chen kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Caveh Jalali caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Ravishankar Sarawadi ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Zhuohao Lee zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Hank Lin hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: Ravishankar Sarawadi ravishankar.sarawadi@intel.corp-partner.google.com
Gerrit-CC: Sathyanarayana Nujella sathyanarayana.nujella@intel.com
Gerrit-Comment-Date: Wed, 22 Jul 2020 03:17:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali caveh@chromium.org
Gerrit-MessageType: comment