Attention is currently required from: Arthur Heymans, Christian Walter, Eric Lai, Felix Singer, Nico Huber, Patrick Rudolph, Paul Menzel, Tim Chu.
Ziang Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75740?usp=email )
Change subject: soc/intel/xeon_sp/spr: Fix memory max capacity per processor
......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75740/comment/8a026e8c_378c9e80 :
PS1, Line 2: wanghao11
Please use your full name and not the user name: […]
Done
https://review.coreboot.org/c/coreboot/+/75740/comment/1514fa78_1866ca6c :
PS1, Line 10:
Was there a user visible problem? If yes, please describe it, and also document how you tested your […]
Done
https://review.coreboot.org/c/coreboot/+/75740/comment/5a8ee974_91e6512c :
PS1, Line 12: Signed-off-by: wanghao11 wanghao11@inspur.com
Ditto.
Done
File src/soc/intel/xeon_sp/spr/romstage.c:
https://review.coreboot.org/c/coreboot/+/75740/comment/065ba73b_ba545e42 :
PS1, Line 277: * Persistent Memory 300 Series mapped as memory) per Socket
Can use this way to do it? https://source.chromium. […]
@Nico: '3DS' here refers to '3D stacking‘ which is a memory packaging technology I guess, it increases the memory density. And yes, 6TiB is the sum of max. DRAM and max. Optane Mem possible.
@Eric: I agree it is a more organized way, but this change is only for SPR-SP (under xeon-sp/spr), and seems like there is only one possible case, so I am not very motivated to add a soc overrider for it...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75740?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb892d3b148291b35808d634d63b58b90d456767
Gerrit-Change-Number: 75740
Gerrit-PatchSet: 5
Gerrit-Owner: Ziang Wang
ziang.wang@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 12 Jun 2023 08:06:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment