Attention is currently required from: Michał Żygowski, Martin Roth, Patrick Rudolph. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52564 )
Change subject: drivers/efi: Add UEFI variable store option support ......................................................................
Patch Set 6:
(7 comments)
File src/drivers/efi/efivars.h:
https://review.coreboot.org/c/coreboot/+/52564/comment/d54a417c_130cf8ab PS5, Line 27: * efi_fv_get_option
efi_fv_set_option
Done
https://review.coreboot.org/c/coreboot/+/52564/comment/1fe44819_f58aea15 PS5, Line 39: size_t size);
We use uint32_t above for size parameter. […]
Done
File src/drivers/efi/efivars.c:
https://review.coreboot.org/c/coreboot/+/52564/comment/2ac300d7_fc671b9d PS5, Line 22: 0xFFF12B8D, 0x7696, 0x4C8B, { 0xA9, 0x85, 0x27, 0x47, 0x07, 0x5B, 0x4F, 0x50 } };
Some capital letters remained
Done
https://review.coreboot.org/c/coreboot/+/52564/comment/063a9c7d_5f9b85f0 PS5, Line 290: static cb_err_t print(struct region_device *rdev, VARIABLE_HEADER *hdr, size_t hdr_size,
print is too generic, I would change it to print_var for example to give the function a meaning what […]
Done
https://review.coreboot.org/c/coreboot/+/52564/comment/94ffb422_b9382690 PS5, Line 361: if (hdr.State == (uint8_t) (-1) || : hdr.DataSize == (uint32_t) (-1) || : hdr.NameSize == (uint32_t) (-1) || : hdr.Attributes == (uint32_t) (-1)) {
Maybe use UINT32_MAX and UINT8_MAX from stdint. […]
Done
https://review.coreboot.org/c/coreboot/+/52564/comment/c283c520_24bb952f PS5, Line 461: if (auth_hdr.State != (uint8_t) (-1) || : auth_hdr.DataSize != (uint32_t) (-1) || : auth_hdr.NameSize != (uint32_t) (-1) || : auth_hdr.Attributes != (uint32_t) (-1)) {
a/a
Done
https://review.coreboot.org/c/coreboot/+/52564/comment/89a5fa4d_35afe16c PS5, Line 531: if (hdr.State != (uint8_t) (-1) || : hdr.DataSize != (uint32_t) (-1) || : hdr.NameSize != (uint32_t) (-1) || : hdr.Attributes != (uint32_t) (-1)) { : return CB_EFI_ACCESS_ERROR; : }
a/a
Done