Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29563 )
Change subject: security/tpm: Fix TCPA log feature ......................................................................
Patch Set 51:
(11 comments)
https://review.coreboot.org/#/c/29563/51/Documentation/security/vboot/measur... File Documentation/security/vboot/measured_boot.md:
https://review.coreboot.org/#/c/29563/51/Documentation/security/vboot/measur... PS51, Line 39: that we could implement it. whitespace What does it mean for coreboot? Do we implement either one of them?
https://review.coreboot.org/#/c/29563/51/Documentation/security/vboot/measur... PS51, Line 63: ``` move above example output
https://review.coreboot.org/#/c/29563/51/Documentation/security/vboot/measur... PS51, Line 64: So we decided to provide and easy understandable TCPA log which can be read out an
https://review.coreboot.org/#/c/29563/51/Documentation/security/vboot/measur... PS51, Line 65: from the operating system and firmware log itself. firmware itself
https://review.coreboot.org/#/c/29563/51/Documentation/security/vboot/measur... PS51, Line 70: e one prefix only
https://review.coreboot.org/#/c/29563/51/src/security/tpm/tspi/log.c File src/security/tpm/tspi/log.c:
https://review.coreboot.org/#/c/29563/51/src/security/tpm/tspi/log.c@25 PS51, Line 25: #include <cbmem.h> cbmem.h included twice
https://review.coreboot.org/#/c/29563/51/src/security/tpm/tspi/log.c@30 PS51, Line 30: MAYBE_STATIC MAYBE_STATIC makes no sense if you don't check if tclt is non NULL and return it early.
https://review.coreboot.org/#/c/29563/51/src/security/tpm/tspi/log.c@81 PS51, Line 81: printk(BIOS_INFO, use full 80 char line length
https://review.coreboot.org/#/c/29563/51/src/security/tpm/tspi/log.c@102 PS51, Line 102: if (!tclt) add warning, too
https://review.coreboot.org/#/c/29563/51/src/security/tpm/tspi/log.c@136 PS51, Line 136: BIOS_INFO BIOS_ERR
https://review.coreboot.org/#/c/29563/51/util/cbmem/cbmem.c File util/cbmem/cbmem.c:
https://review.coreboot.org/#/c/29563/51/util/cbmem/cbmem.c@722 PS51, Line 722: printf(" %s [%s]\n", use full 80 chars per line