1 Jul
2024
1 Jul
'24
5:05 p.m.
Attention is currently required from: Hung-Te Lin, Paul Menzel, Rui Zhou, cong yang.
Yu-Ping Wu has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/83287?usp=email )
Change subject: mb/google/geralt: change config to FW_config for support TAS2563 audio amp ......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/geralt/chromeos.c:
https://review.coreboot.org/c/coreboot/+/83287/comment/06a741ad_87cc8168?usp... : PS7, Line 64: fw_config_probe
sorry,I use vim and vscode to view it locally and it is normal, but after submitting it... […]
Please set tab width to 8 for coreboot (add `set tabstop=8` in .vimrc).
--
To view, visit https://review.coreboot.org/c/coreboot/+/83287?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie9f0cbc30dd950b85581fc1924fa351efe1e0aab
Gerrit-Change-Number: 83287
Gerrit-PatchSet: 9
Gerrit-Owner: Rui Zhou zhourui@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: cong yang yangcong5@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Rui Zhou zhourui@huaqin.corp-partner.google.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: cong yang yangcong5@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 01 Jul 2024 15:05:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rui Zhou zhourui@huaqin.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com