Attention is currently required from: Raul Rangel, Martin Roth, Rob Barnes.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58982 )
Change subject: src/lib/prog_loaders: Add preload_ramstage
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/58982/comment/5504ae97_dc15f8b3
PS3, Line 1219: $(CONFIG_CBFS_PREFIX)/ramstage-align := 64
Minimum alignment for file data is unspecified. […]
I wouldn't say it's unofficial... at least my intention with CB:47827 was to make it official. There should be no more way for cbfstool to produce file data (or attributes) not aligned by 4.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58982
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe12de806449da25bc0033b02fcb97c3384eddc1
Gerrit-Change-Number: 58982
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Comment-Date: Tue, 16 Nov 2021 17:59:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Patrick Georgi
patrick@coreboot.org
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment