Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42960 )
Change subject: mb/google/dedede: Create Drawcia Legacy variant ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42960/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/42960/1/src/mainboard/google/dedede... PS1, Line 15: select BASEBOARD_DEDEDE_LAPTOP
I think the drawcia here would be used by proto development now so should it be still with 32MB SPI […]
Marco, I think it will be easiest for everyone to understand if Drawcia legacy is always 32M, and Drawcia is always 16M.
https://review.coreboot.org/c/coreboot/+/42960/1/src/mainboard/google/dedede... PS1, Line 18: bool "Drawcia" Using the same name here seems dangerous. Maybe "Drawcia (Legacy)" or "Drawcia (32M)"