Attention is currently required from: Yidi Lin, cong yang.
Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74135 )
Change subject: mb/google/corsola: Report SKU and panel ID for unprovisioned devices ......................................................................
Patch Set 6:
(2 comments)
This change is ready for review.
File src/mainboard/google/corsola/boardid.c:
https://review.coreboot.org/c/coreboot/+/74135/comment/a53d6c12_fb957a14 PS5, Line 78: adc_voltages_table = adc_voltages_detachable; : assert(channel < ARRAY_SIZE(adc_voltages_detachable));
check the channel count before the assignment.
Done
https://review.coreboot.org/c/coreboot/+/74135/comment/71324f7a_4c6bf094 PS5, Line 98: /* Return the Panel ID. The ADC channel 5 used for panel id : in starmie board. : */
/* Detachables use ADC channel 5 for panel ID */
Done