[coreboot-gerrit] [S] Change in coreboot[master]: drivers/intel/fsp2_0: Add saving MRC data after FSP-S option

[Jian-Ming Wang (Code Review)]

Jian-Ming Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71950 )

Change subject: drivers/intel/fsp2_0: Add saving MRC data after FSP-S option
......................................................................

Patch Set 9: Code-Review+1

(1 comment)

File src/drivers/intel/fsp2_0/save_mrc_data.c:

https://review.coreboot.org/c/coreboot/+/71950/comment/aba36a8f_8eb58cdd 
PS9, Line 46: if !CONFIG(SAVE_MRC_AFTER_FSPS)
            : BOOT_STATE_INIT_ENTRY(BS_PRE_DEVICE, BS_ON_ENTRY, save_mrc_data, NULL);
            : #elif CONFIG(SAVE_MRC_AFTER_FSPS)
            : BOOT_STATE_INIT_ENTRY(BS_DEV_INIT_CHIPS, BS_ON_EXIT, save_mrc_data, NULL);
            : #endif
> I didn't write the original patch, but I agree that the form you suggest is slightly better so I wen […]

I think the judgement is depending on whether the original idea is to use this definition to tell compiler to include the code into binary. From performance and code size perspective the original one possibly is (slightly?) better. From readability and static/dynamic code analysis perspective, the suggestion from Elyes is better. I think the change might be safe if it passed compiling stage.