Attention is currently required from: Raul Rangel, Karthik Ramasubramanian, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62903 )
Change subject: mb/google/skyrim: Add DXIO descriptors ......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/skyrim/port_descriptors.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144200): https://review.coreboot.org/c/coreboot/+/62903/comment/07de5c86_609039a2 PS2, Line 22: //.port_params = {PP_PSPP_AC, 0x144, PP_PSPP_DC, 0x133} // TODO: uncomment this when PSPP is working line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144200): https://review.coreboot.org/c/coreboot/+/62903/comment/bb0f0985_da034f7d PS2, Line 49: //.port_params = {PP_PSPP_AC, 0x144, PP_PSPP_DC, 0x133} // TODO: uncomment this when PSPP is working line over 96 characters