Puthikorn Voravootivat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32018 )
Change subject: mb/google/poppy/variants/atlas: DPTF tuning v2
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32018/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32018/2//COMMIT_MSG@7
PS2, Line 7: mb/google/poppy/variants/atlas: DPTF tuning v2
Please make it a statement next time.
Ack
Also it’s not clear, what the *v2* in the commit message summary adds in value.
On other platform we used "Update DPTF parameters" as commit message but we do update it multiple times. When I do git log --oneline there would be multiple CL with same summary so I added v2.
Any better suggestion?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32018
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I872c3f1875d0cbac148c44c449954e6871c9d0b0
Gerrit-Change-Number: 32018
Gerrit-PatchSet: 2
Gerrit-Owner: Puthikorn Voravootivat
puthik@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Puthikorn Voravootivat
puthik@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 22 Mar 2019 17:57:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment