Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43771 )
Change subject: mb/google/volteer: Only enable TBT root ports if USB4 is supported
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43771/2/src/mainboard/google/voltee...
File src/mainboard/google/volteer/romstage.c:
https://review.coreboot.org/c/coreboot/+/43771/2/src/mainboard/google/voltee...
PS2, Line 34: /* If the DB is USB3 disable TBT on the platform */
: if (fw_config_probe(FW_CONFIG(DB_USB, USB3_ACTIVE)) ||
: fw_config_probe(FW_CONFIG(DB_USB, USB3_PASSIVE))) {
: mem_cfg->TcssItbtPcie0En = 0;
: mem_cfg->TcssItbtPcie1En = 0;
: mem_cfg->TcssDma0En = 0;
: mem_cfg->TcssDma1En = 0;
: }
makes sense... […]
Marking resolved so I can submit as I have a patch that goes on top of this.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43771
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I594f2e9483aaf896de2b6aea9a3460bd3826c58c
Gerrit-Change-Number: 43771
Gerrit-PatchSet: 4
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Kane Chen
kane.chen@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 14 Aug 2020 16:01:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-MessageType: comment