Attention is currently required from: Angel Pons, Patrick Rudolph.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60001 )
Change subject: soc/intel/{skylake/cannonlake}: Fix bug in vr_config
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
Nice find.
Using units in a function names is a great way of avoiding such issues (in not strongly typed langue as C) ^^
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60001
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe9e0db6762eee5cc363f8b371c8538eb92f6308
Gerrit-Change-Number: 60001
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 09 Dec 2021 11:35:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment