Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42301 )
Change subject: mb/google/volteer: Modify Delbin variant ......................................................................
Patch Set 11:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42301/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42301/11//COMMIT_MSG@13 PS11, Line 13: BRANCH=volteer no branch yet.
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/delbin/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 54: device pci 1f.3 on : end
Turn off it?
1f.3 is HD audio, i don't think you want to turn it off. however, i think you can remove these 2 lines as they match devicetree.cb.
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 64: SBU sbu is fixed since you have a ps8815 in the path. this should be the same as C1.
https://review.coreboot.org/c/coreboot/+/42301/11/src/mainboard/google/volte... PS11, Line 56: device pci 1f.2 hidden : # The pmc_mux chip driver is a placeholder for the : # PMC.MUX device in the ACPI hierarchy. : chip drivers/intel/pmc_mux : device generic 0 on : chip drivers/intel/pmc_mux/conn : register "usb2_port_number" = "9" : register "usb3_port_number" = "1" : # SBU & HSL follow CC : device generic 0 on end : end : chip drivers/intel/pmc_mux/conn : register "usb2_port_number" = "4" : register "usb3_port_number" = "2" : # SBU is fixed, HSL follows CC : register "sbu_orientation" = "TYPEC_ORIENTATION_NORMAL" : device generic 1 on end : end : end : end : end # PMC
Delbin only support typec usb3. […]
yes, for type-C ports connected to the TCP0..3 ports on the SoC, this is needed.