Attention is currently required from: Hung-Te Lin, Shelley Chen, Yu-Ping Wu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68871 )
Change subject: mem_chip_info: Update to new format ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2:
I think at least the corsola is using this feature and has been branched. […]
Done. I hope it's branched but not shipped yet?
File src/commonlib/bsd/include/commonlib/bsd/mem_chip_info.h:
https://review.coreboot.org/c/coreboot/+/68871/comment/0a89ccc0_8d842720 PS2, Line 68: mem_chip_info
should we add some version / size tags, in case if we'll want to change the structure again in the f […]
I can add a little struct version but I'd rather hope we never need to use it.
https://review.coreboot.org/c/coreboot/+/68871/comment/2bc8dfc8_c8201384 PS2, Line 70: uint8_t reserved[3];
should we reserve 7 bytes, for 64-bit alignment? or make the structure declared as __attribute__((pa […]
The whole struct only contains <= 32-bit fields now, so only needs 32-bit alignment. I prefer to avoid __packed where possible. because it tends to screw up code generation unnecessarily.