Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34287 )
Change subject: soc/intel/{cnl,icl}: Always use CAR NEM enhanced by default
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34287/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34287/2//COMMIT_MSG@13
PS2, Line 13:
In #coreboot@irc.freenode.net it was mentioned, that FSP-T is needed for Secure Boot, and that all affected boards in the repository use `MAINBOARD_HAS_CHROMEOS`, so this change actually has no effect. If this is correct, could you please extend the commit message correspondingly?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34287
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I30b1808f91701c07dce6f1de08c213150e8a675a
Gerrit-Change-Number: 34287
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Boon Tiong Teo
boon.tiong.teo@intel.com
Gerrit-Reviewer: Kin Wai Ng
kin.wai.ng@intel.com
Gerrit-Reviewer: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Maurice Ma
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 15 Jul 2019 11:17:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment