Change subject: device/oprom/realmode: Add vbe return status support as per VBE spec 3.0
......................................................................
Patch Set 10:
(1 comment)
@nico, would you like to pay one more look, i know you don't like to review OpRom code but still, this CL is hanging for very long time and i need to get rid of this work
I already looked at the current patch set yesterday. You didn't
fix the address problem I tried to explain. If you need more help
to understand the problem, I fear you have to ask another reviewer.
Did you mean do like below for video_mode_ptr as well ?
(segment << 4) + offset
so in this case
(0x0000 << 4) + 0x0668 == 0x00668
Yes. Preferably before the conversion to `u32 *`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33737
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iacd2ce468e038a14424f029df3a0adec3e5fa15c
Gerrit-Change-Number: 33737
Gerrit-PatchSet: 11
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 12 Jul 2019 12:34:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment