Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44521 )
Change subject: sb/intel/i82371eb/fadt.c: Use macro for 'flags' instead of magic number
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44521/1/src/southbridge/intel/i8237...
File src/southbridge/intel/i82371eb/fadt.c:
https://review.coreboot.org/c/coreboot/+/44521/1/src/southbridge/intel/i8237...
PS1, Line 104: (
no need for parens
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44521
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I793afe81fbb9abef0d4178af9dc2e91c612b1b43
Gerrit-Change-Number: 44521
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 18 Aug 2020 12:12:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment