Attention is currently required from: Martin Roth, Henry Sun, Paul Menzel, Weimin Wu, Karthik Ramasubramanian.
zanxi chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51016 )
Change subject: mb/google/dedede/var/storo:Add P-sensor for storo
......................................................................
Patch Set 5:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51016/comment/3b42a73d_299d0f29
PS2, Line 2: chenzanxi
Please use *Zanxi Chen* (see `git config` and `git commit --amend --author ""`).
Done
https://review.coreboot.org/c/coreboot/+/51016/comment/a045e9c6_902cf561
PS2, Line 7: mb/google/dedede/var/storo:Add P-sensor for storo
Please add a space after the colon.
Done
https://review.coreboot.org/c/coreboot/+/51016/comment/f18a1b37_a4f6829b
PS2, Line 8: Add P-sensor into devicetree for storo.
Please add a blank line above.
Done
File src/mainboard/google/dedede/variants/storo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/51016/comment/d1df0358_dfe699de
PS2, Line 47: [PchSerialIoIndexI2C0] = PchSerialIoPci,
Then I’d say that the baseboard devicetree is “wrong”. […]
Done
File src/mainboard/google/dedede/variants/storo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/51016/comment/7bf5dabe_a4886528
PS3, Line 48: [PchSerialIoIndexI2C1] = PchSerialIoPci,
Is Digitizer required to be enabled?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51016
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iced4ab7d94b38ef8b1807955cbb887454accb1e8
Gerrit-Change-Number: 51016
Gerrit-PatchSet: 5
Gerrit-Owner: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 01 Mar 2021 07:39:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment