Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38247 )
Change subject: soc/intel/common/cse: Add consistent HECI command id/group id naming ......................................................................
Patch Set 3: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/38247/3/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/38247/3/src/soc/intel/common/block/... PS3, Line 164: /* Command GLOBAL_RESET_REQ Reset Types */ : #define GLOBAL_RESET 1 : #define HOST_RESET_ONLY 2 : #define CSE_RESET_ONLY 3 nit: This should probably be moved up under MKHI_CBM_GLOBAL_RESET_REQ on line 27.
https://review.coreboot.org/c/coreboot/+/38247/3/src/soc/intel/common/block/... PS3, Line 170: #define MKHI_HMRFPO_DISABLED 0 : #define MKHI_HMRFPO_LOCKED 1 : #define MKHI_HMRFPO_ENABLED 2 nit: This should probably be moved up under MKHI_HMRFPO_GET_STATUS on line 34.