Attention is currently required from: Balaji Manigandan, Felix Singer, Hannah Williams, Kapil Porwal, Paul Menzel, Subrata Banik, Subrata Banik, Tarun Tuli, Usha P, Utkarsh H Patel, Vikrant Jadeja.
Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75717?usp=email )
Change subject: intelblocks/pep: Send All Monitor Off/On command only in FWCM case
......................................................................
Patch Set 9:
(1 comment)
File src/soc/intel/common/block/acpi/pep.c:
https://review.coreboot.org/c/coreboot/+/75717/comment/f4a8f354_506bd070 :
PS9, Line 253: acpigen_write_if_cond_ref_of(THUNDERBOLT_DEVICE);
: acpigen_write_store_int_to_namestr(1, THUNDERBOLT_IOM_DPOF);
: acpigen_write_if_end();
can you please create a helper function and just perform ON/OFF by passing arg0 to the helper functi […]
Subrata, ah right. I noticed the other part of the code that configures for s0ix entry/exit (line 234--243,262--271) and display on/off (line289--298, 304--313) also have the similar repeated code. Is it okay to clean up this file after landing this change? Please let me know what you think. Thank you.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75717?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I110fb971846f110e7d93a524ceda3bf4bfc15c13
Gerrit-Change-Number: 75717
Gerrit-PatchSet: 9
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Utkarsh H Patel
utkarsh.h.patel@intel.com
Gerrit-Reviewer: Utkarsh H Patel
utkarsh.h.patel@intel.corp-partner.google.com
Gerrit-Reviewer: Vikrant Jadeja
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Hannah Williams
hannah.williams@intel.com
Gerrit-Attention: Vikrant Jadeja
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Utkarsh H Patel
utkarsh.h.patel@intel.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Comment-Date: Tue, 27 Jun 2023 04:24:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment