[coreboot-gerrit] [XL] Change in coreboot[main]: soc/intel/ptl: Do initial Panther Lake SoC commit till ramstage

[Saurabh Mishra (Code Review)]

Attention is currently required from: Kapil Porwal, Pranava Y N, Subrata Banik.

Saurabh Mishra has posted comments on this change by Saurabh Mishra. ( https://review.coreboot.org/c/coreboot/+/83798?usp=email )

Change subject: soc/intel/ptl: Do initial Panther Lake SoC commit till ramstage
......................................................................

Patch Set 57:

(11 comments)

This change is ready for review.

File src/soc/intel/pantherlake/acpi.c:

https://review.coreboot.org/c/coreboot/+/83798/comment/937aa9fe_38b97d3b?usp... :
PS56, Line 149: NULL
> this is void function, can't return NULL

Ack, updated.

https://review.coreboot.org/c/coreboot/+/83798/comment/f6943705_4941f92f?usp... :
PS56, Line 163: NULL
> same

Ack, updated.

https://review.coreboot.org/c/coreboot/+/83798/comment/33fc3ac9_97ec6127?usp... :
PS56, Line 239: DEBUG
> BIOS_DEBUG will anyway add `[DEBUG]` , why we need again a msg called DEBUG

Ack, removed.

https://review.coreboot.org/c/coreboot/+/83798/comment/3aa2c7f8_c90eb8dd?usp... :
PS56, Line 240: MCHBAR32(GFXVTBAR), MCHBAR64(GFXVTBAR)
> Why are printing the same `GFXVTBAR` with different macros like MCHBAR32 and MCHBAR64 ??

Hi Subrata, simplified to print only GFXVTBAR =0x%llx

https://review.coreboot.org/c/coreboot/+/83798/comment/bce34044_2026b993?usp... :
PS56, Line 244: DEBUG
> same

Ack, removed.

https://review.coreboot.org/c/coreboot/+/83798/comment/97706795_38949b09?usp... :
PS56, Line 258: DEBUG
> same

Ack, removed.

https://review.coreboot.org/c/coreboot/+/83798/comment/4a143ace_4bcbcfc3?usp... :
PS56, Line 275: DEBUG
> same

Ack, removed.

https://review.coreboot.org/c/coreboot/+/83798/comment/160ea218_3146d2a1?usp... :
PS56, Line 351: NULL
> this is void function. […]

Ack, updated.

File src/soc/intel/pantherlake/chip.c:

https://review.coreboot.org/c/coreboot/+/83798/comment/dc81a587_3bde6546?usp... :
PS56, Line 167: NULL
> this is void fuction. […]

Ack, updated.

File src/soc/intel/pantherlake/cpu.c:

https://review.coreboot.org/c/coreboot/+/83798/comment/bf0876db_8a7d60db?usp... :
PS56, Line 129: NULL
> this is a `void` function. You can't return any data type here. […]

Ack, updated.

https://review.coreboot.org/c/coreboot/+/83798/comment/e4302026_45e4d320?usp... :
PS56, Line 172: return NULL;
> same

Ack, updated.