Martin L Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75910?usp=email )
Change subject: soc/intel/common: Print crashlog size info in hex ......................................................................
soc/intel/common: Print crashlog size info in hex
Print crashlog size information in hex to be consistent with other prints.
BUG=b:262501347 TEST=Values printed in hex.
Signed-off-by: Pratikkumar Prajapati pratikkumar.v.prajapati@intel.com Change-Id: Ieb5498e702497bfbc2b4d5396d5b760a0010f5de Reviewed-on: https://review.coreboot.org/c/coreboot/+/75910 Reviewed-by: Kapil Porwal kapilporwal@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/common/block/acpi/acpi_bert.c 1 file changed, 6 insertions(+), 6 deletions(-)
Approvals: build bot (Jenkins): Verified Kapil Porwal: Looks good to me, approved
diff --git a/src/soc/intel/common/block/acpi/acpi_bert.c b/src/soc/intel/common/block/acpi/acpi_bert.c index 37309de..350d5d3 100644 --- a/src/soc/intel/common/block/acpi/acpi_bert.c +++ b/src/soc/intel/common/block/acpi/acpi_bert.c @@ -56,12 +56,12 @@ if (cpu_record_size) { cl_data = new_cper_fw_error_crashlog(status, cpu_record_size); if (!cl_data) { - printk(BIOS_ERR, "Crashlog CPU entry(size %zu) " + printk(BIOS_ERR, "Crashlog CPU entry(size 0x%zx) " "would exceed available region\n", cpu_record_size); return CB_ERR; } - printk(BIOS_DEBUG, "cl_data %p, cpu_record_size %zu\n", + printk(BIOS_DEBUG, "cl_data %p, cpu_record_size 0x%zx\n", cl_data, cpu_record_size); cl_fill_cpu_records(cl_data); } @@ -77,12 +77,12 @@
cl_data = new_cper_fw_error_crashlog(status, pmc_record_size); if (!cl_data) { - printk(BIOS_ERR, "Crashlog PMC entry(size %zu) " + printk(BIOS_ERR, "Crashlog PMC entry(size 0x%zx) " "would exceed available region\n", pmc_record_size); return CB_ERR; } - printk(BIOS_DEBUG, "cl_data %p, pmc_record_size %zu\n", + printk(BIOS_DEBUG, "cl_data %p, pmc_record_size 0x%zx\n", cl_data, pmc_record_size); cl_fill_pmc_records(cl_data); } @@ -99,12 +99,12 @@
cl_data = new_cper_fw_error_crashlog(status, ioe_record_size); if (!cl_data) { - printk(BIOS_ERR, "Crashlog IOE entry(size %zu) " + printk(BIOS_ERR, "Crashlog IOE entry(size 0x%zx) " "would exceed available region\n", ioe_record_size); return CB_ERR; } - printk(BIOS_DEBUG, "cl_data %p, ioe_record_size %zu\n", + printk(BIOS_DEBUG, "cl_data %p, ioe_record_size 0x%zx\n", cl_data, ioe_record_size); cl_fill_ioe_records(cl_data); }