Attention is currently required from: Andrey Petrov, Dinesh Gehlot, Jayvik Desai, Ronak Kanabar, Subrata Banik.
Paul Menzel has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/83770?usp=email )
Change subject: drivers/intel/fsp2: Add config for FSP uGOP eSOL ......................................................................
Patch Set 6:
(3 comments)
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/83770/comment/0dc9d658_7b5a2bbd?usp... : PS6, Line 476: This utilizes Intel's underlying uGOP : technology Is this too much marketing speech? Maybe:
The uGOP graphics driver part of FSP-M is used for this.
(Or is it μGOP?)
https://review.coreboot.org/c/coreboot/+/83770/comment/33af8db2_b2341c79?usp... : PS6, Line 477: sign of life In the current code base it’s spelled Sign-of-Life. (No idea, if we should stay consistent. Feel free to ignore.)
https://review.coreboot.org/c/coreboot/+/83770/comment/74ddc0c9_7e139ddd?usp... : PS6, Line 475: Enable the FSP-M Sign-of-Life feature to display a text message : on screen during memory training and CSME update. This utilizes Intel's underlying uGOP : technology to enable early sign of life (eSOL) as part of FSP-M. Please re-flow.