[coreboot-gerrit] [M] Change in coreboot[master]: arch/arm64: Add EL1/EL2/EL3 support for arm64

[Maximilian Brune (Code Review)]

Attention is currently required from: Arthur Heymans, Christian Walter, David Milosevic, Julius Werner, Lean Sheng Tan, Nico Huber.

Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74798?usp=email )

Change subject: arch/arm64: Add EL1/EL2/EL3 support for arm64
......................................................................

Patch Set 5:

(1 comment)

File src/arch/arm64/transition_asm.S:

https://review.coreboot.org/c/coreboot/+/74798/comment/9684d1c7_c09f8506 :
PS5, Line 155: 	mrs	x1, currentel
> No, that one's good the way you wrote it, you should always prefer C `if()` over preprocessor `#if`  […]

I know its like this in most of our code, but personally I don't understand why I would want to prefer `ìf()` over `#if`
It makes more sense to me to use preprocessor directives for things that are known at preprocessor phase (like CONFIG_* variables). Using preprocessor for CONFIG_* variable checking would also get rid of the dead_code macro, since you can just use `#error` right? Seems wrong to depend on the compiler to optimize it out.