[coreboot-gerrit] Change in coreboot[master]: mb/google/volteer: Separate power resource for VCM

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )

Change subject: mb/google/volteer: Separate power resource for VCM
......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:

https://review.coreboot.org/c/coreboot/+/45159/3/src/mainboard/google/voltee... 
PS3, Line 345:                 Method (_ON, 0, Serialized)  /* VCPR_ON_: VCM Power On */
> Sorry, I don't know anything about SSDT, could you elaborate what effort is planned and what's the E […]

Tomasz, we are referring to coreboot generating AML at runtime and emitting it into the SSDT versus having ASL files directly in the DSDT. See CB:41758 for an example of converting jslrvp to this model. Using this driver will correctly generate enable and disable methods for each GPIO and clock that use reference counting to ensure proper power sequencing.