Attention is currently required from: Varshit Pandya.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80287?usp=email )
Change subject: vc/amd/opensil/genoa_poc: remove xSIM-api dependency from opensil.h ......................................................................
Patch Set 1:
(1 comment)
File src/vendorcode/amd/opensil/genoa_poc/ramstage.c:
https://review.coreboot.org/c/coreboot/+/80287/comment/5c92bb1f_d27c440d : PS1, Line 178: /* TODO: also call timepoints 2 and 3 from coreboot. Are they NOOP? */
Can this be removed now ?
no, this shouldn't be removed yet, since coreboot isn't calling time points 2 and 3. this patch just adds one function to call for each timepoint