Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33382 )
Change subject: [WIP] mb/google/{sarien, arcada} Fix for SSD can't be detected issue ......................................................................
Patch Set 6:
(2 comments)
Patch Set 5:
(1 comment)
The change seems largely fine now. At what point will your team have confidence and want to remove the WIP and commit it?
We are running some cold/warm reboot cycles, I will check to see when will they be done.
https://review.coreboot.org/#/c/33382/4/src/mainboard/google/sarien/romstage... File src/mainboard/google/sarien/romstage.c:
https://review.coreboot.org/#/c/33382/4/src/mainboard/google/sarien/romstage... PS4, Line 72: gpio_set(GPIO_SSD_RESET, 1);
Yes,this is to keep the pulse shorter in warm reset case (Requirement was >10ms). […]
Done
https://review.coreboot.org/#/c/33382/5/src/mainboard/google/sarien/romstage... File src/mainboard/google/sarien/romstage.c:
https://review.coreboot.org/#/c/33382/5/src/mainboard/google/sarien/romstage... PS5, Line 67: if (acpi_get_sleep_type() == ACPI_S5) {
just a comment here to explain why this is necessary
Done