Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36626 )
Change subject: util/lint/kconfig_lint: Handle glob prefix and suffix
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/36626/1/util/lint/kconfig_lint
File util/lint/kconfig_lint:
https://review.coreboot.org/c/coreboot/+/36626/1/util/lint/kconfig_lint@1231
PS1, Line 1231: $dir_glob_prefix
My google-foo says we should escape the variables (in case they contain […]
Done
https://review.coreboot.org/c/coreboot/+/36626/1/util/lint/kconfig_lint@1231
PS1, Line 1231:
looks like this file uses spaces only for indentation
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36626
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9067a95ff171d6da58583b3d4f15596b4584d937
Gerrit-Change-Number: 36626
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 05 Nov 2019 12:40:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment