[coreboot-gerrit] Change in coreboot[master]: drivers/spi/tpm: Add helper to identify how cr50 sees AP reset

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44653 )

Change subject: drivers/spi/tpm: Add helper to identify how cr50 sees AP reset
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44653/1/src/drivers/spi/tpm/tpm.h 
File src/drivers/spi/tpm/tpm.h:

https://review.coreboot.org/c/coreboot/+/44653/1/src/drivers/spi/tpm/tpm.h@4... 
PS1, Line 48: cr50_sees_ap_reset_on_sys_reset
> I prefer option 1.

On a second thought, passing firmware version seems more generic than the cr50_firmware_pltrst_on_wrong_pin. May be more use-cases in future might benefit out of it than this one-off helper function. I will go ahead and implement a getter function to get the firmware version.