[coreboot-gerrit] Change in coreboot[master]: drivers/intel/dptf: Add missing Scope operator for _FIF

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43840 )

Change subject: drivers/intel/dptf: Add missing Scope operator for _FIF
......................................................................

drivers/intel/dptf: Add missing Scope operator for _FIF

Missed one other scope operator in the DPTF cleanup. This one is for the
fan device, and without this fix, the kernel isn't able to properly
control the fan (it gets confused about whether it's ACPI 4+ compatible
or not).

BUG=b:149722146
TEST=verify /sys/class/thermal/cooling_zone0/max_state returns > 1,
and /sys/class/thermal/cooling_zone0/cur_state is writable, and writing
the value of `max_state` causes the fan to spin faster.

Signed-off-by: Tim Wawrzynczak 
Change-Id: I7bd83967ace761ddd17eaeae9c25abb0b2cbe413
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43840
Tested-by: build bot (Jenkins) 
Reviewed-by: Furquan Shaikh 
---
M src/drivers/intel/dptf/dptf.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Furquan Shaikh: Looks good to me, approved

diff --git a/src/drivers/intel/dptf/dptf.c b/src/drivers/intel/dptf/dptf.c
index a13f6d0..0f1cc9c 100644
--- a/src/drivers/intel/dptf/dptf.c
+++ b/src/drivers/intel/dptf/dptf.c
@@ -209,9 +209,11 @@
    int i;

/* Fan options */
+	dptf_write_scope(DPTF_FAN);
    dptf_write_fan_options(config->options.fan.fine_grained_control,
    		       config->options.fan.step_size,
    		       config->options.fan.low_speed_notify);
+	acpigen_pop_len(); /* Scope */

/* TSR options */
    for (p = DPTF_TEMP_SENSOR_0, i = 0; p <= DPTF_TEMP_SENSOR_3; ++p, ++i) {