[coreboot-gerrit] [S] Change in coreboot[master]: aopen/dxplplusu: Use ACPI_COMMON_MADT_IOAPIC

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74352 )

Change subject: aopen/dxplplusu: Use ACPI_COMMON_MADT_IOAPIC
......................................................................

aopen/dxplplusu: Use ACPI_COMMON_MADT_IOAPIC

IRQ override from IRQ #0 to GSI #2 is changed from
MP_BUS_EISA to MP_BUS_ISA.

Change-Id: I115df037fd79e120b04e6aff9e53f963f045b997
Signed-off-by: Kyösti Mälkki 
---
M src/mainboard/aopen/dxplplusu/Kconfig
M src/mainboard/aopen/dxplplusu/acpi_tables.c
M src/southbridge/intel/i82801dx/Kconfig
3 files changed, 15 insertions(+), 9 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/74352/1

diff --git a/src/mainboard/aopen/dxplplusu/Kconfig b/src/mainboard/aopen/dxplplusu/Kconfig
index 5c0ca2b..7d374f4 100644
--- a/src/mainboard/aopen/dxplplusu/Kconfig
+++ b/src/mainboard/aopen/dxplplusu/Kconfig
@@ -2,6 +2,7 @@

config BOARD_SPECIFIC_OPTIONS
    def_bool y
+	select ACPI_CUSTOM_MADT
    select CPU_INTEL_SOCKET_MPGA604
    select NORTHBRIDGE_INTEL_E7505
    select SOUTHBRIDGE_INTEL_I82870
diff --git a/src/mainboard/aopen/dxplplusu/acpi_tables.c b/src/mainboard/aopen/dxplplusu/acpi_tables.c
index ba9d3c8..e22b454 100644
--- a/src/mainboard/aopen/dxplplusu/acpi_tables.c
+++ b/src/mainboard/aopen/dxplplusu/acpi_tables.c
@@ -8,9 +8,6 @@
    struct device *bdev, *dev = NULL;
    struct resource *res = NULL;

-	/* Southbridge IOAPIC */
-	current += acpi_create_madt_ioapic_from_hw((acpi_madt_ioapic_t *)current, 0xfec00000);
-
    bdev = pcidev_on_root(2, 0);
    /* P64H2 Bus B IOAPIC */
    if (bdev)
@@ -28,11 +25,5 @@
    	current += acpi_create_madt_ioapic_from_hw((acpi_madt_ioapic_t *)current, res->base);
    }

-	/* Map ISA IRQ 0 to IRQ 2 */
-	current += acpi_create_madt_irqoverride((acpi_madt_irqoverride_t *)current, 1, 0, 2, 0);
-
-	/* IRQ9 differs from ISA standard - ours is active high, level-triggered */
-	current += acpi_create_madt_irqoverride((acpi_madt_irqoverride_t *)current, 0, 9, 9, 0xD);
-
    return current;
 }
diff --git a/src/southbridge/intel/i82801dx/Kconfig b/src/southbridge/intel/i82801dx/Kconfig
index 2be911d..8393f38 100644
--- a/src/southbridge/intel/i82801dx/Kconfig
+++ b/src/southbridge/intel/i82801dx/Kconfig
@@ -2,6 +2,7 @@

config SOUTHBRIDGE_INTEL_I82801DX
    bool
+	select ACPI_COMMON_MADT_IOAPIC
    select ACPI_COMMON_MADT_LAPIC
    select ACPI_INTEL_HARDWARE_SLEEP_VALUES
    select HAVE_SMI_HANDLER