Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47559 )
Change subject: intel/fsp2_0: Add soc_validate_fsp_version for FSP version check ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47559/1/src/drivers/intel/fsp2_0/ut... File src/drivers/intel/fsp2_0/util.c:
https://review.coreboot.org/c/coreboot/+/47559/1/src/drivers/intel/fsp2_0/ut... PS1, Line 250: __weak void soc_validate_fsp_version(const struct fsp_header *hdr) { }
Maybe print a DEBUG __func__ not implemented on this weak call. We should encourage version checks.
Done