Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45608 )
Change subject: soc/intel/xeon_sp: Improve performance efficiencies
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45608/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45608/4//COMMIT_MSG@9
PS4, Line 9: IIO_RESOUCE_INSTANCE
RESOURCE
https://review.coreboot.org/c/coreboot/+/45608/4//COMMIT_MSG@11
PS4, Line 11: PASS_BY_REFERENCE.
Maybe mention, that the performance difference probably does not matter for coreboot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45608
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ae9ae38fe2c13c5433aa5e1dcbb30ebd30622ab
Gerrit-Change-Number: 45608
Gerrit-PatchSet: 4
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 28 Sep 2020 20:06:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment