Attention is currently required from: Arthur Heymans, Cliff Huang, Fred Reitberger, Jason Glenesk, Lance Zhao, Matt DeVillier, Nico Huber, Tim Wawrzynczak.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80464?usp=email )
Change subject: soc/amd: move common pci_domain_fill_ssdt implementation to acpi/
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
I had a look at Intel client .asl code if that could be replaced with this code. […]
i think the oprom area didn't need to be a resource producer when i tested. but might be that that just worked fine on AMD silicon, since it uses the VFCT when using the iGPU. i don't think that adding the oprom area would break anything for the AMD code, so that could probably just be added. when you add that, please add me as a reviewer and i'll run a test on mandolin to make sure that this won't cause a regression. windows tends to be really picky about this
File src/acpi/Kconfig:
https://review.coreboot.org/c/coreboot/+/80464/comment/45feee21_f192b84b :
PS1, Line 101: ACPI_PCI_ROOT_RESOURCE_PRODUCER
How about "acpi(gen)_domain_resources"?
hmm, it's probably not needed. let me push an updated version that adds this to the build unconditionally; the makefile already makes sure that it's only added for x86
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80464?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7bd8568cf0b7051c74adbedfe0e416a0938ccb99
Gerrit-Change-Number: 80464
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Cliff Huang
cliff.huang@intel.com
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Cliff Huang
cliff.huang@intel.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Tue, 13 Feb 2024 15:02:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment