Attention is currently required from: Martin L Roth, Maxim Polyakov, ron minnich.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59958 )
Change subject: util/docker/coreboot.org-status: Rewrite parser ......................................................................
Patch Set 16:
(6 comments)
Patchset:
PS16: Maxim, thanks for the review!
File util/docker/coreboot.org-status/board-status.html/boards.go:
https://review.coreboot.org/c/coreboot/+/59958/comment/8822dc76_55515e75 PS11, Line 20: if len(spl) != 2 {
An empty line, or one without a colon returns an array with less than 2 elements. […]
Clarified in a comment.
File util/docker/coreboot.org-status/board-status.html/logs.go:
https://review.coreboot.org/c/coreboot/+/59958/comment/0b8c8f17_c5bdae45 PS15, Line 26: _
logging of this error is not required? […]
It's put on os.Stderr now.
https://review.coreboot.org/c/coreboot/+/59958/comment/568e5f5c_5b697f75 PS15, Line 61: item
What happens if the string doesn't contain the ":" character? […]
It's caught now.
https://review.coreboot.org/c/coreboot/+/59958/comment/fcc73231_ea53173e PS15, Line 93: [3]
check len(pieces) needed?
Done
File util/docker/coreboot.org-status/board-status.html/status-to-html.go:
https://review.coreboot.org/c/coreboot/+/59958/comment/17f5ded2_67989795 PS15, Line 71: dirs
Why are you using the channel here? Why not a slice? In my opinion, it would be better to abandon mu […]
I used it more as a structuring mechanism, akin to unix pipes. I don't see how it's easier if I collect everything in an array and pass that one around.