Attention is currently required from: Tarun Tuli, Dinesh Gehlot.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74209 )
Change subject: soc/intel/: Implement an API to get ISH version
......................................................................
Patch Set 9:
(1 comment)
File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/74209/comment/132e8f73_2d51823f
PS5, Line 547: if the latest ISH version is not updated in the CBMEM table
Ah, you meant “not up to date”.
Maybe:
… if the ISH version in CBMEM table outdated
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74209
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib3f983d5de5b169474bcdb1e9e2934174a9dadf8
Gerrit-Change-Number: 74209
Gerrit-PatchSet: 9
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Comment-Date: Wed, 12 Apr 2023 07:49:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dinesh Gehlot
digehlot@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment