Attention is currently required from: Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Nick Vaccaro. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57069 )
Change subject: coreboot tables: Add type-c port info to coreboot table ......................................................................
Patch Set 29:
(4 comments)
File payloads/libpayload/include/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/57069/comment/b2f0221a_6a748894 PS26, Line 173: struct cb_type_c_info {
This is not needed as well.
Done
File payloads/libpayload/include/sysinfo.h:
https://review.coreboot.org/c/coreboot/+/57069/comment/8af9f7f6_98ddb5cb PS26, Line 153: typec_orientation
type_c_orientation. […]
Done
File payloads/libpayload/libc/coreboot.c:
https://review.coreboot.org/c/coreboot/+/57069/comment/467fe689_3405f070 PS26, Line 251: get_cbmem_addr
(void *)
Done
File src/commonlib/include/commonlib/coreboot_tables.h:
https://review.coreboot.org/c/coreboot/+/57069/comment/842e85dc_7428d8ad PS27, Line 431: enum type_c_orientation {
You will have to pull in the change to src/drivers/intel/pmc_mux/conn/chip. […]
I would also have to bring in a change to conn.c as well. To avoid that, I removed the add of enum of type_c_orientation from this CL and added the change to move and convert the enum typec_orientation into the connector CL.
Is that ok, or is it better to bring in two changes from driver in this CL instead?