[coreboot-gerrit] [XS] Change in coreboot[main]: include/assert.h: Deal with GCC LTO false positives

[Yu-Ping Wu (Code Review)]

Attention is currently required from: Arthur Heymans, Hung-Te Lin, Yidi Lin.

Yu-Ping Wu has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84208?usp=email )

Change subject: include/assert.h: Deal with GCC LTO false positives
......................................................................

Patch Set 5: Code-Review+2

(1 comment)

File src/include/assert.h:

https://review.coreboot.org/c/coreboot/+/84208/comment/462eec44_0a0db01d?usp... :
PS5, Line 28: 	(__builtin_constant_p(x) && !(CONFIG(LTO) && CONFIG(COMPILER_GCC)) ? \
I wonder if it would be clearer to write

```
#if CONFIG(LTO) && CONFIG(COMPILER_GCC)
#define __build_time_assert(x) 0
#else
#define __build_time_assert(x) (__builtin_constant_p ...
#endif
```