[coreboot-gerrit] Change in coreboot[master]: util/lint/checkpatch: Decrease commit message line length limit to 72

[Martin Roth (Code Review)]

Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/60006 )

Change subject: util/lint/checkpatch: Decrease commit message line length limit to 72
......................................................................

util/lint/checkpatch: Decrease commit message line length limit to 72

Currently, `checkpatch.pl`, imported from the Linux project, checks for
75 characters per line [2]:
> Suggest line wrapping at 75 columns so the default git commit log
> indentation of 4 plus the commit message text still fits on an 80
> column screen.

But Gerrit’s Web interface and its commit hooks use with 72 characters
per line [2]:

remote: commit 35bb56d: warning: too many message lines longer than 72 characters; manually wrap lines
    remote:
    remote: SUCCESS
    remote:
    remote:   https://review.coreboot.org/c/coreboot/+/60004 [DO NOT SUBMIT] Gerrit commit msg line length test [NEW]

So, decrease the suggested length from 75 to 72 characters per line.

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i...
[2]: https://review.coreboot.org/60004

Change-Id: Ic9c686cb1a902259b18377b76b5c999e94660fed
Signed-off-by: Paul Menzel 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60006
Tested-by: build bot (Jenkins) 
Reviewed-by: Martin Roth 
---
M util/lint/checkpatch.pl
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved

diff --git a/util/lint/checkpatch.pl b/util/lint/checkpatch.pl
index f1c31c5..41aae93 100755
--- a/util/lint/checkpatch.pl
+++ b/util/lint/checkpatch.pl
@@ -2655,9 +2655,9 @@
    		$commit_log_possible_stack_dump = 1;
    	}

-# Check for line lengths > 75 in commit log, warn once
+# Check for line lengths > 72 in commit log, warn once
    	if ($in_commit_log && !$commit_log_long_line &&
-		    length($line) > 75 &&
+		    length($line) > 72 &&
    	    !($line =~ /^\s*[a-zA-Z0-9_/.]+\s+|\s+\d+/ ||
    				# file delta changes
    	      $line =~ /^\s*(?:[\w.-]+/)++[\w.-]+:/ ||
@@ -2666,7 +2666,7 @@
    				# A Fixes: or Link: line
    	      $commit_log_possible_stack_dump)) {
    		WARN("COMMIT_LOG_LONG_LINE",
-			     "Possible unwrapped commit description (prefer a maximum 75 chars per line)\n" . $herecurr);
+			     "Possible unwrapped commit description (prefer a maximum 72 chars per line)\n" . $herecurr);
    		$commit_log_long_line = 1;
    	}