Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41758 )
Change subject: mb/intel/jasperlake_rvp: Camera remove DSDT and enable SSDT
......................................................................
Patch Set 11:
(3 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/41758/11//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41758/11//COMMIT_MSG@7
PS11, Line 7: mb/intel/jasperlake_rvp: Camera SSDT changes for JSLRVP
Please make it a statement by adding a verb in imperative mood. (Currently it’s also too generic.) […]
Done
https://review.coreboot.org/c/coreboot/+/41758/8/src/mainboard/intel/jasperl...
File src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/41758/8/src/mainboard/intel/jasperl...
PS8, Line 386: 450000000
symbolic constant?
Done
https://review.coreboot.org/c/coreboot/+/41758/8/src/mainboard/intel/jasperl...
PS8, Line 404: device pci 05.0 on end # RP4
So a PCI device (00:05.0) underneath another PCI device (00:19.1) ? 00:05. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41758
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib439572bc1d15ef02c86c7bfa88af6b16eb06f97
Gerrit-Change-Number: 41758
Gerrit-PatchSet: 11
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kiran2 Kumar
kiran2.kumar@intel.corp-partner.google.com
Gerrit-CC: Matt Delco
delco@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 23 Jun 2020 11:02:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt Delco
delco@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment