Attention is currently required from: Felix Singer, Name of user not set #1003506, Martin Roth, Michael Niewöhner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52594 )
Change subject: mainboard: Add Synology DS918+
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52594/comment/c57cf657_697da6c5
PS1, Line 15: * find out how to tell the OS that this board has no video output.
Any issue with that? […]
Also disable `device pci 02.0` in the devicetree (it's the iGPU)
File src/mainboard/synology/ds918plus/bootblock.c:
https://review.coreboot.org/c/coreboot/+/52594/comment/067d2041_6a76aa44
PS1, Line 12: lpc_configure_pads();
I can't find it anywhere and it's breaking the compiling. […]
It got removed in CB:49410 and it's easy to fix: configure LPC in the early GPIO table.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52594
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib837e0819c97a617e5558480e7cdac05e3cff185
Gerrit-Change-Number: 52594
Gerrit-PatchSet: 1
Gerrit-Owner: Name of user not set #1003506
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Name of user not set #1003506
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Thu, 22 Apr 2021 13:40:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Gerrit-MessageType: comment