Attention is currently required from: Julius Werner.
Alex James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60233 )
Change subject: util/cbfstool: Replace swab.h with commonlib/bsd/sysincludes.h
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
Yes, please just do that, this file is obsolete (at least for those functions).
Done. I also removed is_big_endian in common.c, which was otherwise unused outside of swab.h.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60233
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54195865ab4042fcf83609fcf67ef8f33994d68e
Gerrit-Change-Number: 60233
Gerrit-PatchSet: 2
Gerrit-Owner: Alex James
theracermaster@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Tue, 21 Dec 2021 01:21:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Alex James
theracermaster@gmail.com
Gerrit-MessageType: comment