Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44498 )
Change subject: nb/amd/agesa: define DDR3_SPD_SIZE as a common value
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44498/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44498/1//COMMIT_MSG@9
PS1, Line 9: Move a size of DDR3 SPD memory (always 256 bytes) to a common define.
Um, but replace the other instances of `256` as well?
Sadly it's really not obvious (at least to me) which of these references are guaranteed to stand for SPD size. I replaced only one for which I'm 100% confident, to be on the safe side.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44498
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80c89ff6e44526e1d75b0e933b21801ed17c98c0
Gerrit-Change-Number: 44498
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 18 Aug 2020 19:26:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Mike Banon
mikebdp2@gmail.com
Gerrit-MessageType: comment