Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36821 )
Change subject: vendorcode/eltan/security: Remove cbfs prepare and locate ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/36821/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36821/1//COMMIT_MSG@10 PS1, Line 10: eltan verified boot is the only software using. This isn really required
isn't
Done
https://review.coreboot.org/c/coreboot/+/36821/1/src/vendorcode/eltan/securi... File src/vendorcode/eltan/security/verified_boot/vboot_check.c:
https://review.coreboot.org/c/coreboot/+/36821/1/src/vendorcode/eltan/securi... PS1, Line 336: if (prog->type == PROG_REFCODE)
Might split into 2 patch sets. […]
Will do that
https://review.coreboot.org/c/coreboot/+/36821/1/src/vendorcode/eltan/securi... PS1, Line 343: process_verify_list( ramstage_verify_list );
remove space
Will be in next patch set
https://review.coreboot.org/c/coreboot/+/36821/2/src/vendorcode/eltan/securi... File src/vendorcode/eltan/security/verified_boot/vboot_check.c:
https://review.coreboot.org/c/coreboot/+/36821/2/src/vendorcode/eltan/securi... PS2, Line 330: prog_locate_hook
You might want to update the comment describing this optional hook. […]
I noted this and will create a patch for that change as well
https://review.coreboot.org/c/coreboot/+/36821/2/src/vendorcode/eltan/securi... PS2, Line 343:
one tab too much
Will be resolved in new patch