build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59714 )
Change subject: util/cbfstool: Port elogtool to libflashrom ......................................................................
Patch Set 1:
(186 comments)
File util/cbfstool/uflashrom.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/dd9fe3e3_ba2c2895 PS1, Line 9: const char *programmer; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/ba1b37f9_f32b6a6f PS1, Line 9: const char *programmer; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/cceee54b_c5bfcbf5 PS1, Line 10: uint32_t size; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/ac00a756_39912af3 PS1, Line 10: uint32_t size; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/b2df3632_9ec40e5c PS1, Line 11: uint8_t *data; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/008ee169_a51ee173 PS1, Line 11: uint8_t *data; please, no spaces at the start of a line
File util/cbfstool/uflashrom.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/296a1174_7f003409 PS1, Line 15: va_list ap) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/89ec0db4_079ef873 PS1, Line 15: va_list ap) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/fb5a02d6_22d08509 PS1, Line 17: int ret = 0; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/69d62ee0_b44bf669 PS1, Line 17: int ret = 0; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/664c5aba_7e4f9996 PS1, Line 18: FILE *output_type = (level < FLASHROM_MSG_INFO) ? stderr : stdout; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/16a28b65_848228a9 PS1, Line 18: FILE *output_type = (level < FLASHROM_MSG_INFO) ? stderr : stdout; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/e151eea1_c228b36b PS1, Line 20: if (level > g_verbose_screen) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/f1ac4f40_dbde8a02 PS1, Line 20: if (level > g_verbose_screen) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/c29d202e_dfa8314e PS1, Line 21: return ret; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/9868be78_b2d5efba PS1, Line 21: return ret; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/0b0dd4ef_d3934346 PS1, Line 23: ret = vfprintf(output_type, fmt, ap); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/ca44e660_6d7a840a PS1, Line 23: ret = vfprintf(output_type, fmt, ap); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/b43825b9_bd4b9c1c PS1, Line 24: /* msg_*spew often happens inside chip accessors code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/deccffd1_6562df5b PS1, Line 25: * in possibly time-critical operations. code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/d452c83c_5412a507 PS1, Line 26: * Don't slow them down by flushing. code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/cc13b7f7_1d7b9cbe PS1, Line 27: */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/296e7fd9_a8024161 PS1, Line 28: if (level != FLASHROM_MSG_SPEW) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/a03b5b6a_153d0cc8 PS1, Line 28: if (level != FLASHROM_MSG_SPEW) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/aa2eb497_a847e35c PS1, Line 29: fflush(output_type); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/8d0aa20e_eead1d2a PS1, Line 29: fflush(output_type); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/cedd6fd7_426d1bf0 PS1, Line 31: return ret; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/de4ca997_ec42127f PS1, Line 31: return ret; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/fc97b102_7cccaa1e PS1, Line 36: int r = 0; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/e9b3bbea_3d1359e9 PS1, Line 36: int r = 0; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/00a11c6d_d04f71c0 PS1, Line 37: size_t len = 0; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/5988e85e_f8701c06 PS1, Line 37: size_t len = 0; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/6e579764_79758a25 PS1, Line 39: struct flashrom_programmer *prog = NULL; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/5273b50e_26fe405d PS1, Line 39: struct flashrom_programmer *prog = NULL; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/5c1a7f89_18f9ab77 PS1, Line 40: struct flashrom_flashctx *flashctx = NULL; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/4f49cfae_a52f61cb PS1, Line 40: struct flashrom_flashctx *flashctx = NULL; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/ed4ccf31_11473d03 PS1, Line 41: struct flashrom_layout *layout = NULL; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/def0e3c3_ee6e2adc PS1, Line 41: struct flashrom_layout *layout = NULL; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/4ef777ba_360d87e8 PS1, Line 43: flashrom_set_log_callback((flashrom_log_callback *)&flashrom_print_cb); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/f2681fa7_667002d2 PS1, Line 43: flashrom_set_log_callback((flashrom_log_callback *)&flashrom_print_cb); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/7fa4ceff_9e8d80f5 PS1, Line 45: r |= flashrom_init(1); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/7de24780_c6394ae3 PS1, Line 45: r |= flashrom_init(1); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/8f65a252_35134322 PS1, Line 46: r |= flashrom_programmer_init(&prog, image->programmer, NULL); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/f8d5c367_cbbeba5c PS1, Line 46: r |= flashrom_programmer_init(&prog, image->programmer, NULL); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/4c12085a_7bfd1dcd PS1, Line 47: r |= flashrom_flash_probe(&flashctx, prog, NULL); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/cb5a7269_8dbb3dc5 PS1, Line 47: r |= flashrom_flash_probe(&flashctx, prog, NULL); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/bd6a3163_37fe9765 PS1, Line 49: len = flashrom_flash_getsize(flashctx); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/09f3134e_958f197e PS1, Line 49: len = flashrom_flash_getsize(flashctx); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/ebeee55e_c0dc3cf2 PS1, Line 50: if (region) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/d2ec5868_ccd6f56e PS1, Line 50: if (region) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/4d409118_db99ec21 PS1, Line 51: r = flashrom_layout_read_fmap_from_rom( code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/588c94ee_392a31cf PS1, Line 51: r = flashrom_layout_read_fmap_from_rom( please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/6311e8f2_e1c0d2cc PS1, Line 52: &layout, flashctx, 0, len); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/b5ef17f2_2442b0b8 PS1, Line 52: &layout, flashctx, 0, len); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/f7071302_6e413c16 PS1, Line 53: if (r > 0) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/9d598ed7_9388bbd1 PS1, Line 53: if (r > 0) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/6380f0b8_b2e3da1d PS1, Line 54: ERROR("could not read fmap from rom, r=%d\n", r); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/85f0bfa5_e4e6a082 PS1, Line 54: ERROR("could not read fmap from rom, r=%d\n", r); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/5416df1c_dd9f6860 PS1, Line 55: r = -1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/8d324b87_b35dfec3 PS1, Line 55: r = -1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/974b9256_ff91a75c PS1, Line 56: goto err_cleanup; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/c7276eda_2ec04601 PS1, Line 56: goto err_cleanup; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/371443dd_99ecac4c PS1, Line 57: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/d1cb0e03_518d714e PS1, Line 57: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/9811ac86_aa368178 PS1, Line 58: // empty region causes seg fault in API. code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/9c9c82de_28240500 PS1, Line 59: r |= flashrom_layout_include_region(layout, region); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/d079cf8b_d46a0073 PS1, Line 59: r |= flashrom_layout_include_region(layout, region); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/1eef204a_266d42c5 PS1, Line 60: if (r > 0) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/3b08175c_308e2126 PS1, Line 60: if (r > 0) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/bae6709a_e11ed4d5 PS1, Line 61: ERROR("could not include region = '%s'\n", region); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/4b2966f1_bf040712 PS1, Line 61: ERROR("could not include region = '%s'\n", region); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/2ffd6866_68d0f036 PS1, Line 62: r = -1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/b5e1a919_4bcc1815 PS1, Line 62: r = -1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/6785dff4_d2b5cd6f PS1, Line 63: goto err_cleanup; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/4eec44ba_d0a2e0eb PS1, Line 63: goto err_cleanup; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/9ae3b2e3_51cd04af PS1, Line 64: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/1efda331_997239ed PS1, Line 64: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/1e3383ba_7611dc0f PS1, Line 65: flashrom_layout_set(flashctx, layout); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/ccf8b867_ce7b9c4d PS1, Line 65: flashrom_layout_set(flashctx, layout); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/afcf791e_f0776ebd PS1, Line 66: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/6772b9e3_e96203d5 PS1, Line 66: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/cb547b6c_0c49c277 PS1, Line 67: image->data = calloc(1, len); // XXX code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/5da573bd_39041653 PS1, Line 67: image->data = calloc(1, len); // XXX please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/ce007300_7f433d92 PS1, Line 68: image->size = len; // XXX code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/c4d8aedb_a0ffc0ab PS1, Line 68: image->size = len; // XXX please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/9c1a65a8_329f9a99 PS1, Line 70: r |= flashrom_image_read(flashctx, image->data, len); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/68e19770_8dc21fad PS1, Line 70: r |= flashrom_image_read(flashctx, image->data, len); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/5a7bb0ef_14effb88 PS1, Line 72: r |= flashrom_programmer_shutdown(prog); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/cca2d45d_289044ca PS1, Line 72: r |= flashrom_programmer_shutdown(prog); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/16e7a53a_03ec0784 PS1, Line 73: flashrom_flash_release(flashctx); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/0eae38f6_c5bd4608 PS1, Line 73: flashrom_flash_release(flashctx); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/dc0c9dda_a0ea40dc PS1, Line 75: return r; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/1b9a1415_75aff560 PS1, Line 75: return r; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/9a396b04_54534fd4 PS1, Line 80: int r = 0; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/7cddbbed_d5cb13eb PS1, Line 80: int r = 0; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/7ea60416_fd94c074 PS1, Line 81: size_t len = 0; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/bb1d0ee3_30874a0b PS1, Line 81: size_t len = 0; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/8f93b39b_46688007 PS1, Line 83: struct flashrom_programmer *prog = NULL; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/8cd6f549_f0c11162 PS1, Line 83: struct flashrom_programmer *prog = NULL; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/caec51eb_3fdbec3e PS1, Line 84: struct flashrom_flashctx *flashctx = NULL; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/b5e74816_055ee6e1 PS1, Line 84: struct flashrom_flashctx *flashctx = NULL; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/a0b43e5b_7f32a16b PS1, Line 85: struct flashrom_layout *layout = NULL; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/e057af3b_7e14ade8 PS1, Line 85: struct flashrom_layout *layout = NULL; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/0f6d87f8_f957f47d PS1, Line 87: flashrom_set_log_callback((flashrom_log_callback *)&flashrom_print_cb); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/fd2dda60_2ddd5d7b PS1, Line 87: flashrom_set_log_callback((flashrom_log_callback *)&flashrom_print_cb); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/7173596b_7142c107 PS1, Line 89: r |= flashrom_init(1); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/236e37f2_4b76d4d6 PS1, Line 89: r |= flashrom_init(1); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/6ee5c131_b5ea4ccd PS1, Line 90: r |= flashrom_programmer_init(&prog, image->programmer, NULL); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/cbd56773_0e8bb4d5 PS1, Line 90: r |= flashrom_programmer_init(&prog, image->programmer, NULL); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/bfac3d39_0ce8652d PS1, Line 91: r |= flashrom_flash_probe(&flashctx, prog, NULL); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/dd502acb_91754b0a PS1, Line 91: r |= flashrom_flash_probe(&flashctx, prog, NULL); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/d8526262_77ee1ab5 PS1, Line 93: len = flashrom_flash_getsize(flashctx); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/f5bc452e_81afb76c PS1, Line 93: len = flashrom_flash_getsize(flashctx); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/bf0b681b_cf887369 PS1, Line 94: if (len == 0) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/370eaaf4_eea84128 PS1, Line 94: if (len == 0) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/a4da47e0_a5c571d1 PS1, Line 95: ERROR("zero sized flash detected\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/b5eff057_a1ead019 PS1, Line 95: ERROR("zero sized flash detected\n"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/083d9c0d_43d78ed9 PS1, Line 96: r = -1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/2d503159_03a49cbb PS1, Line 96: r = -1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/3ba654c3_8f69387e PS1, Line 97: goto err_cleanup; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/e28d8ca3_385725f3 PS1, Line 97: goto err_cleanup; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/025e0ab0_c4325c96 PS1, Line 98: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/96450b8f_dcf22bba PS1, Line 98: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/488653a8_168f2b80 PS1, Line 99: if (region) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/39c4ac41_3eafd5ef PS1, Line 99: if (region) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/b4ba4c22_034d3700 PS1, Line 100: r = flashrom_layout_read_fmap_from_buffer( code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/c38a915a_3ae7643b PS1, Line 100: r = flashrom_layout_read_fmap_from_buffer( please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/2753f1d4_80c349fb PS1, Line 101: &layout, flashctx, (const uint8_t *)image->data, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/4e4bdc3e_21d46c4c PS1, Line 101: &layout, flashctx, (const uint8_t *)image->data, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/00c6533d_1a13af1b PS1, Line 102: image->size); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/7cd27bfc_dfd0082b PS1, Line 102: image->size); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/29e64efd_b042308e PS1, Line 103: if (r > 0) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/d99b875e_892c9397 PS1, Line 103: if (r > 0) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/1d0186f2_57c8df91 PS1, Line 104: WARN("could not read fmap from image, r=%d, " code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/2037e926_9ae18100 PS1, Line 104: WARN("could not read fmap from image, r=%d, " please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/583cab56_b0bec08d PS1, Line 105: "falling back to read from rom\n", r); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/5db8e13c_0251f106 PS1, Line 105: "falling back to read from rom\n", r); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/a7a1b9c1_60264236 PS1, Line 106: r = flashrom_layout_read_fmap_from_rom( code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/6dda1149_cd089f92 PS1, Line 106: r = flashrom_layout_read_fmap_from_rom( please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/4d4b5fcc_29b5e550 PS1, Line 107: &layout, flashctx, 0, len); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/23ac7770_898d6487 PS1, Line 107: &layout, flashctx, 0, len); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/6eb32f83_9fe6ead3 PS1, Line 108: if (r > 0) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/de9890e3_abf87328 PS1, Line 108: if (r > 0) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/8dc014e2_e0f314e0 PS1, Line 109: ERROR("could not read fmap from rom, r=%d\n", r); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/c91ecaf5_50cbb985 PS1, Line 109: ERROR("could not read fmap from rom, r=%d\n", r); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/9230c1d4_f5e0c025 PS1, Line 110: r = -1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/b69f6935_7ee6a700 PS1, Line 110: r = -1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/5c53ae49_ad141bd1 PS1, Line 111: goto err_cleanup; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/0c477c0c_53e0fe11 PS1, Line 111: goto err_cleanup; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/8c22762d_18d59bfe PS1, Line 112: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/23a15643_756ea457 PS1, Line 112: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/0ed73642_7f72d273 PS1, Line 113: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/ae550823_721118ad PS1, Line 113: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/101ab177_78cbd2cb PS1, Line 114: // empty region causes seg fault in API. code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/5adaf4ce_032b1a3c PS1, Line 115: r |= flashrom_layout_include_region(layout, region); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/3c594243_1354bd81 PS1, Line 115: r |= flashrom_layout_include_region(layout, region); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/8aa6cf02_a31c713b PS1, Line 116: if (r > 0) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/5b07633e_8ef410ab PS1, Line 116: if (r > 0) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/0c8adc50_4b6d88e1 PS1, Line 117: ERROR("could not include region = '%s'\n", region); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/3f3d1fc4_d182ae09 PS1, Line 117: ERROR("could not include region = '%s'\n", region); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/f019c11e_8834814b PS1, Line 118: r = -1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/a35de7ef_54ac5e1c PS1, Line 118: r = -1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/23c30fbc_bdd402a2 PS1, Line 119: goto err_cleanup; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/2f4478da_f58d74e2 PS1, Line 119: goto err_cleanup; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/0af04e7d_c54e9028 PS1, Line 120: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/8ef9c5de_40cec81b PS1, Line 120: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/5db4d881_50f9fa77 PS1, Line 121: flashrom_layout_set(flashctx, layout); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/6bc730ac_10a3bf2e PS1, Line 121: flashrom_layout_set(flashctx, layout); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/f34e5786_4e843d9e PS1, Line 122: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/78105d3c_67090000 PS1, Line 122: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/672c7e84_2b7a3eba PS1, Line 124: flashrom_flag_set(flashctx, FLASHROM_FLAG_VERIFY_WHOLE_CHIP, true); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/087e7b27_aec9ed34 PS1, Line 124: flashrom_flag_set(flashctx, FLASHROM_FLAG_VERIFY_WHOLE_CHIP, true); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/4cf300ed_ef259da8 PS1, Line 125: flashrom_flag_set(flashctx, FLASHROM_FLAG_VERIFY_AFTER_WRITE, true); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/b1168290_4d389aa3 PS1, Line 125: flashrom_flag_set(flashctx, FLASHROM_FLAG_VERIFY_AFTER_WRITE, true); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/83c39ef2_d1d9f0fb PS1, Line 127: r |= flashrom_image_write(flashctx, image->data, image->size, NULL); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/fc779c82_c8ef4159 PS1, Line 127: r |= flashrom_image_write(flashctx, image->data, image->size, NULL); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/40b9261d_4e33ebd8 PS1, Line 130: r |= flashrom_programmer_shutdown(prog); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/b68a0286_e2e4f7c7 PS1, Line 130: r |= flashrom_programmer_shutdown(prog); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/6ef3ab6b_e91d029a PS1, Line 131: flashrom_layout_release(layout); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/d7465944_ce6256ee PS1, Line 131: flashrom_layout_release(layout); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/45b3b71c_44396e52 PS1, Line 132: flashrom_flash_release(flashctx); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/c77c98b1_f7e5e266 PS1, Line 132: flashrom_flash_release(flashctx); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/db62ffc9_5cfbaddf PS1, Line 133: free(tmp); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/0907f033_10e0b446 PS1, Line 133: free(tmp); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/704630ad_5f3c8506 PS1, Line 135: return r; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134567): https://review.coreboot.org/c/coreboot/+/59714/comment/8ce72fa6_41f1faf5 PS1, Line 135: return r; please, no spaces at the start of a line