[coreboot-gerrit] [S] Change in coreboot[master]: mb/google/rex: Configure ISH GPIO's based on FW_CONFIG

[Bernardo Perez Priego (Code Review)]

Attention is currently required from: Jamie Ryu, Jay Patel, Kapil Porwal, Li1 Feng, Subrata Banik, Tarun Tuli, Wonkyu Kim.

Bernardo Perez Priego has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75525?usp=email )

Change subject: mb/google/rex: Configure ISH GPIO's based on FW_CONFIG
......................................................................

Patch Set 9:

(2 comments)

File src/mainboard/google/rex/variants/rex0/fw_config.c:

https://review.coreboot.org/c/coreboot/+/75525/comment/c30a0d4b_18ecda8d :
PS8, Line 104: 1
> > I assumed that this CBI should be the mechanism to determine if Proto1 or Proto2. […]

Done. Supporting Proto 1.

https://review.coreboot.org/c/coreboot/+/75525/comment/bad8d359_1c7db658 :
PS8, Line 111: printk(BIOS_ERR, "Unknown Board Version for ISH.\n");
> > I assumed that it would not configure any GPIO pin if board was not determined. […]

Acknowledged