Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45159 )
Change subject: mb/google/volteer: Separate power resource for VCM ......................................................................
Patch Set 11:
(11 comments)
https://review.coreboot.org/c/coreboot/+/45159/6/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/6/src/mainboard/google/voltee... PS6, Line 168: ((
One set of parentheses is enough: […]
Done
https://review.coreboot.org/c/coreboot/+/45159/6/src/mainboard/google/voltee... PS6, Line 187: }
\n
Done
https://review.coreboot.org/c/coreboot/+/45159/6/src/mainboard/google/voltee... PS6, Line 201: ((
Same here, one set of parentheses is enough.
Done
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl:
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 149: Name (REFC, 0)
Would you mind adding a comment here explaining what `REFC` is for?
Done
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 168: If ((REFC == 0))
`If (REFC == 0)`
Done
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 175: REFC = REFC + 1
nit: ASL 2.0 supports […]
Done
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 206: REFC = REFC - 1
nit: ASL 2.0 supports […]
Done
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 352: If ((REFC == 0))
`If (REFC == 0)`
Done
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 357: REFC = REFC + 1
nit: […]
Done
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 362: If ((REFC == 1))
`If (REFC == 1)`
Done
https://review.coreboot.org/c/coreboot/+/45159/7/src/mainboard/google/voltee... PS7, Line 367: REFC = REFC - 1
nit: […]
Done