Attention is currently required from: Eran Mitrani, Subrata Banik, Kapil Porwal, Eric Lai.
Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66992 )
Change subject: mb/google/rex: Add fingerprint SPI
......................................................................
Patch Set 19: Code-Review+2
(1 comment)
File src/mainboard/google/rex/variants/rex0/gpio.c:
https://review.coreboot.org/c/coreboot/+/66992/comment/35265b5f_d269805b
PS14, Line 439: /* GPP_B11 : [] ==> EN_FP_PWR */
: PAD_CFG_GPO(GPP_B11, 0, DEEP),
Not sure, but followed the same procedure as in https://review.coreboot. […]
To be complete, I'd like us to measure (with oscilloscope) and record the timings so we can reference this again (e.g. prove that we are not violating the spec).
1) Period Power is OFF to FPMCU during a reboot
2) Timing between Power being applied to reset being de-asserted
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66992
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e6be24e72a8232ae2c958a01cf8ea9a272d7365
Gerrit-Change-Number: 66992
Gerrit-PatchSet: 19
Gerrit-Owner: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 07 Nov 2022 17:36:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Eran Mitrani
mitrani@google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment