Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32914 )
Change subject: post: during post_code, only call elog when enabled
......................................................................
Patch Set 5:
(1 comment)
Sorry for the patchset upload spam :(
https://review.coreboot.org/#/c/32914/2/src/console/post.c
File src/console/post.c:
https://review.coreboot.org/#/c/32914/2/src/console/post.c@84
PS2, Line 84: ENV_RAMSTAGE
Actually, looking at it, I think this should be broader than just ramstage. what about: […]
I like that better, didn't know about the __PRE_RAM__
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32914
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I766c276f28d46492fb05e0e3be71853e21f4e8e0
Gerrit-Change-Number: 32914
Gerrit-PatchSet: 5
Gerrit-Owner: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Jett Rink
jettrink@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 21 May 2019 21:45:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Gerrit-MessageType: comment